[Ffmpeg-devel] [PATCH] avoid calling a NULL function in swscale.c

[Michael Niedermayer]

Hi

On Thu, Apr 26, 2007 at 02:15:27PM +0200, Benoit Fouet wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> > Hi
> >
> > On Thu, Apr 26, 2007 at 11:29:22AM +0200, Benoit Fouet wrote:
> >   
> >> Hi,
> >>
> >> patch 1: add a test on conversion function prior to try to apply it
> >>     
> >
> > and what is this good for? producing wrong output which is hard to debug
> > instead of segfault which is easy to find the cause of?
> >
> >
> >   
> there's already a message:
> av_log(c, AV_LOG_ERROR, "swScaler: internal error %s -> %s converter\n",
>                  sws_format_name(srcFormat), sws_format_name(dstFormat));
> 
> isn't it enough ?

it is, patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070426/b291688b/attachment.pgp>