[Ffmpeg-devel] Network patch for MingW users

[Ryan Martell]

On Feb 19, 2007, at 4:15 PM, M?ns Rullg?rd wrote:

> Klaas-Pieter Vlieg <vlieg at eurescom.eu> writes:
>>>
>> I don't have the time to improve it so that it meets the tough
>> ffmpeg dev requirements.  Maybe someone has time to do this. I've
>> attached my latest version.

M?ns, Ramiro's patch looked cleaner and simpler; I was wondering why  
it hadn't been reviewed.

>> Kl
>>      len = sizeof(my_addr1);
>>      getsockname(udp_fd, (struct sockaddr *)&my_addr1, &len);
>>      s->local_port = ntohs(my_addr1.sin_port);
>>
>> +#ifdef __MINGW32__
>> +    tmp=65536;   /* 64k UDP buffer size.  Should this be bigger? */
>> +    setsockopt(udp_fd, SOL_SOCKET, SO_RCVBUF, &tmp, sizeof(tmp));
>> +#endif
>
> Why?  Maybe this really is needed, but in that case a comment would be
> nice.

This is talked about before;  Apparently windows only has an 8k  
buffer.  My thought would be to just setsockopt, and not limit it to  
MINGW.  Generally, one would assume that it could handle a 64k  
packet, since that's the limit, but (no surprise) windows can't  
without that line...

Just my 2 cents.
-Ryan