[Ffmpeg-devel] Network patch for MingW users

[Måns Rullgård]

Diego Biurrun said:
> On Wed, Feb 21, 2007 at 12:53:31PM +0100, Alex Beregszaszi wrote:
>>
>> Here is my MinGW networking patch.
>>
>> --- configure	(revision 8047)
>> +++ configure	(working copy)
>> @@ -1097,9 +1097,12 @@
>>      fi
>>      dv1394="no"
>>      ffserver="no"
>> -    network="no"
>>      if enabled wince; then
>> +        network="no"
>>          protocols="no"
>> +    else
>> +        network="yes"
>
> IIRC network is enabled by default so this is redundant.

It is worse than redundant.  It is wrong.  It will override --disable-network
on the command line.

>> +        add_extralibs -lws2_32
>
> This is also added in another place anyway.  It's now added in the
> proper place.

Ought that not be made conditional on network support?

-- 
M?ns Rullg?rd
mans at mansr.com