[Ffmpeg-devel] [PATCH] Build failes on i386 if snow is disabled

[Martin Storsjö]

On Thu, 22 Feb 2007, Diego Biurrun wrote:

> On Thu, Feb 22, 2007 at 01:21:03AM +0200, Martin Storsj? wrote:
>>
>> When building shared libraries of ffmpeg on OS X on i386 with the snow
>> encoder and decoder disabled, the build fails due to an undefined
>> reference to ff_snow_inner_add_yblock in i386/snowdsp_mmx.o. The attached
>> patch fixes this, by only including that object file when building the
>> snow encoder.
>>
>> --- libavcodec/Makefile	(revision 8055)
>> +++ libavcodec/Makefile	(working copy)
>> @@ -327,8 +327,10 @@
>>          i386/vp3dsp_sse2.o \
>>          i386/fft_3dn.o \
>>          i386/fft_3dn2.o \
>> -        i386/snowdsp_mmx.o \
>>
>> +ifeq ($(CONFIG_SNOW_ENCODER),yes)
>> +OBJS += i386/snowdsp_mmx.o
>> +endif
>
> Looks wrong, AFAIR snowdsp_mmx is used by the decoder, not the encoder.
> Maybe both, but surely not just the encoder.

I was able to build a complete ffmpeg using this when enabling only the 
decoder. Additionally, in dsputil_mmx.c, all references to the 
ff_snow-routines are wrapped in CONFIG_SNOW_ENCODER only.

// Martin