[Ffmpeg-devel] [PATCH] cursory edit of doc/snow.txt

[Michael Niedermayer]

Hi

On Fri, Jan 05, 2007 at 09:43:54PM -0800, Corey Hickey wrote:
> Hello,
> 
> I went through doc/snow.txt and made several grammar fixes and some
> wording improvements (I think). Do the changes look good? Please give
> the patch a quick read and make sure I haven't mis-parsed any of the
> original wording. I wasn't sure in a couple parts.
> 
> Thanks,
> Corey

> Index: doc/snow.txt
> ===================================================================
> --- doc/snow.txt	(revision 7409)
> +++ doc/snow.txt	(working copy)
> @@ -6,18 +6,18 @@
>  Definitions:
>  ============
>  
> -MUST    the specific part must be done to conform to this standard
> -SHOULD  it is recommended to be done that way, but not strictly required
> +MUST    This must be done in order to conform to the standard.
> +SHOULD  This is recommended but is not strictly required.

this is from nut.txt so whatever you do do it to nut.txt too


>  qlog
>      quality (logarthmic quantizer scale)
> -    stored as delta from last, last is reset to 0 if always_reset || keyframe
> +    This is stored as delta from the last value.
> +    The last value is reset to 0 if always_reset or the current frame is a keyframe.

IMHO s/if always_reset/if always_reset is 1/

[...]
> -the used luma and chroma is the sum of the predictor and y_diff, cb_diff, cr_diff
> +The luma and chroma values used are the sum of the predictor, y_diff, cb_diff,
> +and cr_diff.

The luma value used is the sum of the luma predictor and y_diff, similarly for
chroma
... seems less ambiguous

rest looked fine ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070106/ad7be3cd/attachment.pgp>