[Ffmpeg-devel] FFmpeg Theora encoding patch

[Diego Biurrun]

On Sun, Jan 07, 2007 at 02:58:25PM +0000, Paul Richards wrote:
> On 06/01/07, M?ns Rullg?rd <mru at inprovide.com> wrote:
> >"Paul Richards" <paul.richards at gmail.com> writes:
> >
> >> Attached is my patch to add theora encoding to ffmpeg's libavcodec (by
> >> using libtheora).  I am requesting help to fix the bug I mention below
> >> and am seeking general comments before I submit the patch properly.
> >>
> >> Files encoded using this encoder have a problem playing in VLC.  The
> >> files will not play unless "Drop late frames" has been unticked in the
> >> advanced video settings.  Hopefully someone can tell me where this
> >> problem comes from.  I am not sure which API (FFmpeg or libtheora) I
> >> am misusing.
> >>
> >> --- libavcodec/vp3.c  (revision 7409)
> >> +++ libavcodec/vp3.c  (working copy)
> >> @@ -2643,7 +2643,6 @@
> >>      NULL
> >>  };
> >>
> >> -#ifndef CONFIG_LIBTHEORA
> >>  AVCodec theora_decoder = {
> >>      "theora",
> >>      CODEC_TYPE_VIDEO,
> >> @@ -2656,4 +2655,3 @@
> >>      0,
> >>      NULL
> >>  };
> >> -#endif
> >
> >Why?
> 
> The author of the vp3 decoder assumed that when libtheora was hooked
> up it would take over the job of theora decoding.  My patch only uses
> libtheora for encoding, and so the vp3 theora decoder is still needed
> despite CONFIG_LIBTHEORA now being defined.

I think this was from before the time when our VP3 decoder supported
Theora.  I don't see a reason to use libtheora for Theora decoding now
that we have a native decoder.

Diego