[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding

[Diego Biurrun]

On Thu, Jan 11, 2007 at 09:38:04PM +0000, Paul Richards wrote:
> On 10/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> >
> >On Mon, Jan 08, 2007 at 09:20:19AM +0000, Paul Richards wrote:
> >>
> >> Here are the file rename, whitespace, and ordering changes you requested.
> >
> >Trailing whitespace is still there.  Please call the configure option
> >--enable-libtheora.  Also, I reordered libavcodec/Makefile and put the
> >external libraries in a separate block, libtheora should go there.
> >
> [snip]
> 
> I previously only removed the trailing newlines at the very end.  I
> didn't realise that trailing whitespace internal to the file was what
> you meant.

There is still some left.

> This is now fixed, as well as renaming the '--enable' flag
> and the libavcodec/Makefile ordering.

Thanks, I like this one much better.  However, I think that the
following

> --- libavcodec/Makefile	(revision 7438)
> +++ libavcodec/Makefile	(working copy)
> @@ -257,6 +257,7 @@
>  OBJS-$(CONFIG_LIBFAAD)                 += faad.o
>  OBJS-$(CONFIG_LIBGSM)                  += libgsm.o
>  OBJS-$(CONFIG_LIBMP3LAME)              += mp3lameaudio.o
> +OBJS-$(CONFIG_THEORA_ENCODER)          += libtheoraenc.o

should be 

  +OBJS-$(CONFIG_LIBTHEORA)               += libtheoraenc.o

as CONFIG_LIBTHEORA is what configure will add to config.mak - if I am
not mistaken...

Diego