[Ffmpeg-devel] missing headers?

[Michael Niedermayer]

Hi

On Wed, Jan 17, 2007 at 02:16:01AM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Tue, Jan 09, 2007 at 07:57:51PM +0300, Pavlov Konstantin wrote:
> >> 
> >> Had some problems recently building SVN version of mplayer with external 
> >> ffmpeg. Looks like mplayer uses some header files which aren't included in 
> >> ffmpeg 'installed' tree.
> >> 
> >> The attached file fixes those problems.
> >> 
> >> --- a/libavformat/Makefile
> >> +++ b/libavformat/Makefile
> >> @@ -8,7 +8,7 @@ CFLAGS+=-I$(SRC_PATH)/libavcodec
> >> -HEADERS = avformat.h avio.h rtp.h rtsp.h rtspcodes.h
> >> +HEADERS = avformat.h avio.h rtp.h rtsp.h rtspcodes.h riff.h
> >>  
> >> --- a/libavutil/Makefile
> >> +++ b/libavutil/Makefile
> >> @@ -18,7 +18,7 @@ OBJS= mathematics.o \
> >>  HEADERS = avutil.h common.h mathematics.h integer.h rational.h \
> >> -          intfloat_readwrite.h md5.h adler32.h log.h fifo.h
> >> +          intfloat_readwrite.h md5.h adler32.h log.h fifo.h bswap.h
> >
> > What about this?
> 
> Rejected.  Those headers are internal to ffmpeg.  Apps have no
> business poking with them, not even mplayer.

libavutil is not just a internal part of libav* so bswap.h must be installed
maybe with different name maybe with renamed functions but it must be installed

about riff.h, the fourcc<->codec id tables and corresponding utility functions
should be in a installed header

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070117/2dd7ca0d/attachment.pgp>