[Ffmpeg-devel] [PATCH]BMP encoder

[Michael Niedermayer]

Hi

On Thu, Jan 25, 2007 at 12:05:03PM +0100, Michel Bardiaux wrote:
> Aurelien Jacobs wrote:
> >On Wed, 24 Jan 2007 15:16:18 +0100
> >Michel Bardiaux <mbardiaux at mediaxim.be> wrote:
> >
> >>M?ns Rullg?rd wrote:
> >>>Michael Niedermayer <michaelni at gmx.at> writes:
> >>>
> >>>[...]
> >>>
> >>>>better put the encoder into its own file
> >>>Yes, please.
> >>OK, I will. That implies moving the BMP_RLE4 etc to a bmp.h, and 
> >>BMPContext. What should I do about the _init method? One for enc and one 
> >>for dec, even if that duplicates the code?
> >
> >Idealy you could `svn mv bmp.c bmpdec.c` 
> 
> Plus some Makefile massage of course.
> 
> >then create a new bmp.c file
> >containing common code for encoder and decoder (with proper declarations
> >in bmp.h).
> >But it may be overkill in this situation, and maybe duplicating this
> >2 lines _init function is ok ?
> >
> >Aurel
> 
> My thoughts exactly.

yes, duplicate that 2 line init function

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070125/8907a840/attachment.pgp>