[Ffmpeg-devel] [PATCH] Dead code cleanup - C++

Diego Biurrun diego
Thu Jan 25 18:37:50 CET 2007


On Fri, Jan 26, 2007 at 01:24:39PM +1030, Yuri Vilmanis wrote:
> 
> >Not true, this project is not supposed to be gcc-only.
> 
> Read your own F.A.Q., section 2.4 & 2.6 (see above). Or clarify it, which may be a better option...

I clarified it, thanks for noticing the outdated sections.

> >iam not aware of any bugreports about this, not to mention iam not aware
> >of any difference betweem gcc and C99 about "static inline" care to
> >elaborate on this? we dont use non static inline or extern inline or anything
> >like that ...
> 
> Some non-static inlines, According To grep:
> ffmpeg/libswscale/swscale_template.c:2663:inline static void RENAME(hcscale)(uint16_t *dst, long dstWidth, uint8_t *src1, uint8_t *src2,
> ffmpeg/libavcodec/motion_est_template.c:236:inline int ff_get_mb_score(MpegEncContext * s, int mx, int my, int src_index,
> ffmpeg/libavcodec/motion_est_template.c:1106:inline int ff_epzs_motion_search(MpegEncContext * s, int *mx_ptr, int *my_ptr,
> ffmpeg/libavcodec/xvmcvideo.c:47:inline void XVMC_init_block(MpegEncContext *s){
> ffmpeg/libavcodec/mpegvideo.c:3331:inline int ff_h263_round_chroma(int x){
> ffmpeg/libavcodec/mpegvideo.h:766:inline int ff_epzs_motion_search(MpegEncContext * s, int *mx_ptr, int *my_ptr,
> ffmpeg/libavcodec/mpegvideo.h:769:inline int ff_get_mb_score(MpegEncContext * s, int mx, int my, int src_index,
> 
> I'll let you fix em, seeing as how they dont exist (I'll just take your word on that).

patches welcome ;)

Diego




More information about the ffmpeg-devel mailing list