[Ffmpeg-devel] ffh264 & coded_frame

[Michael Niedermayer]

Hi

On Thu, Jan 25, 2007 at 04:28:54PM +0100, Luca Abeni wrote:
> Hi,
> 
> I finally found some time to play with ffh264 again, and I found out
> that it sets avctx->coded_frame to NULL.
> Since ffmpeg.c contains code for supporting this situation, I assume
> that avctx->coded_frame == NULL is valid. But this makes impossible to
> know the frame quality, the frame type, and to recognize key frames.
> 
> So, I tried to add support for coded_frame... I came up with the
> attached patch, but I do not know if it is correct (in particular, is it
> ok to set coded_frame = &t->po?).

i guess so / patch looks ok

[...]
> Index: ffmpeg/libavcodec/h264enc.c
> ===================================================================
> --- ffmpeg.orig/libavcodec/h264enc.c	2007-01-25 16:32:12.840459312 +0100
> +++ ffmpeg/libavcodec/h264enc.c	2007-01-25 16:32:27.045299848 +0100
> @@ -2044,6 +2044,10 @@
>      t->frame_num++;
>      if (isIDR)
>          t->IDR_frame_num++;
> +
> +    avctx->coded_frame = (AVFrame *)&t->po;

why that cast?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070125/26038fa7/attachment.pgp>