[Ffmpeg-devel] [PATCH] Dead code cleanup - C++

[Reimar Döffinger]

Hello,
On Fri, Jan 26, 2007 at 07:11:12PM +0100, Ulrich von Zadow wrote:
> Fair enough.
> 
> I assume that this patch is a practical joke and not meant to be
> applied. Please don't take it seriously, as applying it _will_ break
> every existing c++ program that uses libav*. The lines that are removed
> by the patch would need to be inserted into every c++ program using
> libav*. Lines like this are standard in lots of other c libraries that
> are used by c++ programs, as well.

Given that not all public headers do include such wrapping, removing it
would increase consistency (as would adding it to all public headers -
are nested 'extern "C" {' valid?).
Removal would be dependant on a version increase (of course?), so it
should not break things too unexpectedly...
Whether it was a joke in the first place, it is not completely meritless
(though discussing it probably is a waste of time to be honest ;-) )

Greetings,
Reimar D?ffinger