[Ffmpeg-devel] [PATCH] Dead code cleanup - C++

[Reimar Döffinger]

Hello,
On Fri, Jan 26, 2007 at 09:36:50PM +0100, Baptiste Coudurier wrote:
> Reimar D?ffinger wrote:
> > Hello,
> > On Fri, Jan 26, 2007 at 09:23:45PM +0100, Baptiste Coudurier wrote:
> >> Reimar D?ffinger wrote:
> >>> On Fri, Jan 26, 2007 at 08:51:13PM +0100, Baptiste Coudurier wrote:
> >>>> Reimar D?ffinger wrote:
> >>> [...]
> >>>>> Why do you claim that? I don't know if configure does all the magic
> >>>>> needed, but except for the asm it compiles since a long time at least with
> >>>>> ICC...
> >>>>>
> >>>> Did you check recently ? I tried with latest available and it did not,
> >>>> even with --enable-mmx.
> >>> Just checked MPlayer compilation with
> >>> "./configure --disable-esd --enable-freetype --enable-gui --disable-lirc
> >>> --disable-lircc --disable-tv --disable-gif --enable-directfb
> >>> --enable-xvmc --cc=/home/reimar/intel/cc/9.1.045/bin/icc --enable-win32
> >>> --target=generic-linux"
> >>> compiles just fine, so if there's a problem it is at least not with any
> >>> of the libav* stuff.
> >> ??? Do you have the patch from mplayer-dev ml applied ?
> >>
> >> ./configure --cc=/opt/intel/cc/9.1.045/bin/icc --disable-mmx
> >> --enable-gpl --enable-static --enable-mp3lame --enable-faac --enable-dts
> >> --enable-a52 --enable-x264 --enable-faad --enable-pthreads --enable-xvid
> >> --enable-pp --enable-amr_nb --enable-amr_wb --enable-x11grab --disable-v4l
> > 
> > You must disable all asm, not just MMX, that's why the
> > --target=generic-linux
> 
> ffmpeg configure does not have this option.

That's why I only tried with MPlayer, as said I'm not sure ffmpeg configure can
do the necessary magic, but that does not say anything about what the code can
support. IOW at least ICC does not show any problems with respect to C99
compliance.

> I must recognize that  without mmx/asm, ffmpeg becomes horribly slow and
> somewhat useless.

Yep. I was hoping for Intel to fix __attribute__((used)), after all they
claim to support all attributes gcc supports, which is the biggest thing
keeping it from compiling the asm optimizations, too.

Greetings,
Reimar D?ffinger