[Ffmpeg-devel] BeOS cleanup work in progress

[Michael Niedermayer]

Hi

On Sat, Jan 27, 2007 at 09:25:07PM +0100, Fran?ois Revol wrote:
> > > > > -        return errno;
> > > > > +        return av_error_from_errno(errno);
> > > >
> > > > hmm this should be a AVERROR_NOMEM i think? if so it should
> > > > be changed in a seperate commit before the other AVERROR stuff
> > >
> > > No idea, I didn't write that code.
> >
> > sure but the correctness of this affects the need and placement of some
> > function you add so your change depends on first having the above resolved
> 
> So, should I commit this one first ?
> OTH I have nothing against using errno there, but the error won't be of much help to the caller anyway, he'd better know for sure it was ENOMEM.

commit it, errno is wrong, it could even be 0 if lav* is used in a
multithreaded program

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070128/7fe39a24/attachment.pgp>