[Ffmpeg-devel] [PATCH] Fix segfault in bmp decoder

[Michael Niedermayer]

Hi

On Wed, Jan 31, 2007 at 12:43:17PM +0100, Benoit Fouet wrote:
> Michel Bardiaux wrote:
> > Cian Duffy wrote:
> >> On 30/01/07, Michel Bardiaux <mbardiaux at mediaxim.be> wrote:
> >>>
> >>> Michael Niedermayer wrote:
> >>>
> >>> >
> >>> > PS: ive seen alot of mime types on patches but yours had
> >>> > Content-Type: image/x-coreldrawpattern
> >>> >
> >>> I've checked: both debian sarge (stable) and debian etch (testing) ship
> >>> file /etc/mime.types with .pat asserted as being coreldraw. FWIW I was
> >>> able to override that with a ~/.mime.types file containing
> >>>
> >>> text/plain                                 asc txt text diff pot pat
> >>> image/x-coreldrawpattern                        patREMOVED
> >>>
> >>> But I dont like changing debian behavior, so I will in the future
> >>> simply
> >>> use .diff, which seems the recommended extension.
> >>>
> >>> Anyway, the whole mimetypes thing is a terrible mess. Debian etch
> >>> contains no less than 20 packages installing a file named mime.types,
> >>> all in a different place! And the method is basically unsound anyway
> >>> since it is based on extension rather than contents, like 'file' is.
> >>
> >>
> >>
> >> Would it not be significantly easier to use ".patch" as the extension
> >> rather
> >> than ".pat", like most of the rest of the known world does? This should
> >> prevent bad mime typing implementations from mucking around.
> >
> > No, .patch is not known in debian-sarge. They fixed that in etch but
> > its now 2 months late...
> No ???
> you could have done exactly the same thing as you did when adding "pat"
> to your text/plain, but adding "patch" instead, no ?
> anyway, you're right, it's better to have everybody change the pat
> mimetype so that they can have the good mime type for your patches :)

code which assigns the mime type based on only the extension is broken by
design

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070131/c44bba8a/attachment.pgp>