[FFmpeg-devel] [PATCH] Fix connect return EWOULDBLOCK not EINPROGRESS under mingw

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Fri, Jun 29, 2007 at 05:01:04PM -0300, Ramiro Ribeiro Polla wrote:
>> Michael Niedermayer wrote:
>> > Hi
>> >
>> > On Thu, Jun 28, 2007 at 10:59:17PM +0200, elupus wrote:
>> >   
>> >> A connect in windows doesn't return EINPROGRESS as is customary for a non
>> >> blocking socket, it returns EWOULDBLOCK. By redefining WSAEWOULDBLOCK to
>> >> WSAEINPROGRESS tcp.c works just fine. 
>> >>
>> >> EINPROGRESS in windows has some very odd meaning, and wouldn't
>> >> make sense to check for anyway, so think this patch is fine.
>> >>     
>> >
>> > do we have a win32 maintainer?
>> > if there are any volunteers, id be very happy to loose the implicit
>> > ffmpeg-win32 maintainer role
>> >
>> >   
>> 
>> Alex already lists himself as Windows MinGW maintainer, but I also 
>> volunteer for the task.
>> 
>> Ok to add myself next to him?
>
> well i am ok with it ...
> but theres a 50:50 chance alex will flame you (and me) if you do

IMHO having two maintainers for something is good.  It should increase
the chances of at least one of them responding.

-- 
M?ns Rullg?rd
mans at mansr.com