[Ffmpeg-devel] Prefix for img_* functions
Baptiste Coudurier
baptiste.coudurier
Thu Mar 1 17:50:23 CET 2007
Hi
Panagiotis Issaris wrote:
> Hi,
>
> Michael Niedermayer schreef:
>> Hi
>
>> On Thu, Mar 01, 2007 at 05:16:43PM +0100, Panagiotis Issaris wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi,
>>>
>>> Michael Niedermayer schreef:
>>>> Hi
>>>>
>>>> On Mon, Feb 26, 2007 at 03:27:10AM +0100, Panagiotis Issaris wrote:
>>>>> Hi,
>>>>>
>>>>> Shouldn't the img_crop, img_copy and img_pad functions get av_ prefixes?
>>>> yes but the old should stay available under #if version something and
>>>> with deprecated attribute
>>> How would you prefer having the old versions available? Using #define's,
>>> duplicate code or the old functions calling the new ones? Or some other way?
>> #defines seem best after 5sec of thoughts
>
> The attached patch adds the prefixes to img_crop, img_copy and img_pad.
>
> ffmpeg.c | 8 ++++----
> libavcodec/avcodec.h | 12 +++++++++---
> libavcodec/imgconvert.c | 8 ++++----
> libavcodec/imgresample.c | 2 +-
> libavcodec/nuv.c | 2 +-
> libavcodec/utils.c | 2 +-
> 6 files changed, 20 insertions(+), 14 deletions(-)
>
> With friendly regards,
> Takis
While we are at it, why not av_picture_pad/copy/crop ? Those funcs take
AVPicture as arg.
--
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
More information about the ffmpeg-devel
mailing list