[FFmpeg-devel] [PATCH] h264 parallelized

[Diego Biurrun]

On Tue, Sep 04, 2007 at 09:31:36PM +0200, Andreas ?man wrote:
>
> Diego Biurrun wrote:
>> On Tue, Sep 04, 2007 at 03:18:13PM +0200, Andreas ?man wrote:
>>>
>>> +    // edge emu needs blocksize + filter length - 1 (=17x17 for halfpel 
>>> / 21x21 for h264)
>>> +    CHECKED_ALLOCZ(s->allocated_edge_emu_buffer, (s->width+64)*2*21*2); 
>>> //(width + edge + align)*interlaced*MBsize*tolerance
>> Please try to keep lines below 80 characters, same in other places.
>
> I've trimmed the worst offenders

I'd have preferred if you would have trimmed a few more, but I won't
bitch anymore.  Likewise things like

> +                   (s->width+64)*2*21*2); //(width + edge + align)*interlaced*MBsize*tolerance

would IMO profit from a bit more spacing.  However, don't consider this
an objection to your patch.

Diego