[FFmpeg-devel] [PATCH] av_estimate_timings_from_pts corrupt timestamps

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Wed, Sep 05, 2007 at 12:08:48PM +0200, Benoit Fouet wrote:
>   
>> Wolfram Gloger wrote:
>>     
>>> Hi,
>>>
>>>   
>>>       
>>>> On Sat, Aug 25, 2007 at 07:51:45PM -0000, Wolfram Gloger wrote:
>>>>     
>>>>         
>>>>> Hi,
>>>>> =20
>>>>> I guess I finally found the reason for strange initial timestamps with
>>>>> MPEG..
>>>>>       
>>>>>           
>>>> i think the patch is ok, but could you maybe provide some sample + command
>>>> line so we reproduce the bug and that this fixes it before applying it?
>>>>     
>>>>         
>>> Sorry for the delay -- I have uploaded a 1MB sample to mplayerhq in a
>>> folder "07-09-04-ffmpeg-last_IP_pts" with a text file describing
>>> command and output (which differs greatly with and without the patch).
>>> The command is:
>>>
>>> ffmpeg_g -y -v 3 -i 07-09-04-sample.ts -acodec copy -vcodec copy \
>>>  -target dvd x.vob
>>>
>>> and you can get more detail with adding "-dump" to see where the
>>> strange timestamps occur without the patch.
>>>
>>> (There is still a single "timestamp discontinuity" message even with
>>> the patch, which I haven't investigated, but it appears to be more
>>> harmless.)
>>>
>>>   
>>>       
>> i confirm the behavior i get before and after the patch is the same as
>> yours.
>> and regression tests passed unchanged.
>>
>> Michael, ok to apply ?
>>     
>
> ok
>
> [...]
>   
>   

Applied

-- 
Ben
Purple Labs S.A.
www.purplelabs.com