[FFmpeg-devel] [PATCH] configure - simplify grab device selection

[Ramiro Polla]

  wrote:
> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
> 
>> Ramiro Ribeiro Polla wrote:
>>> Hello,
>>>
>>> Attached patches simplify configure by treating grab devices like
>>> normal demuxers. They have a proper check in configure.
>>>
>>> grab_1.diff removes specific --disable-{v4l,v4l2,bktr} options from
>>> configure (--disable-demuxer={video_grab_v4l,v4l2,video_grab_bktr}
>>> should be used instead)
>>>
>> New patch attached seems simpler (it uses the dependency
>> checker). Only v4l devices for now, but the same could be done for
>> bktr, audio_oss...
> 
> Mostly OK, but see below.
> 
>>> grab_2.diff and grab_3.diff removes the video_grab_ prefix from v4l
>>> and bktr and reorders alphabetically. It's ugly IMHO.
>>>
>> Ok to rename?
> 
> I don't mind, but then again, I don't use those bits.

Done. I also renamed grab.c to v4l.c and grab_bktr.c to bktr.c (which 
makes more sense). Getting rid of the idea that the should be only 1 
default grab device.

>> Index: configure
>> ===================================================================
>> --- configure	(revision 10292)
>> +++ configure	(working copy)
>> @@ -122,8 +122,6 @@
>>    echo "  --disable-altivec        disable AltiVec usage"
>>    echo "  --disable-audio-oss      disable OSS audio support [default=no]"
>>    echo "  --disable-audio-beos     disable BeOS audio support [default=no]"
>> -  echo "  --disable-v4l            disable video4linux grabbing [default=no]"
>> -  echo "  --disable-v4l2           disable video4linux2 grabbing [default=no]"
>>    echo "  --disable-bktr           disable bktr video grabbing [default=no]"
>>    echo "  --disable-network        disable network support [default=no]"
>>    echo "  --disable-ipv6           disable ipv6 support [default=no]"
>> @@ -624,8 +622,6 @@
>>      small
>>      swscaler
>>      vhook
>> -    v4l
>> -    v4l2
>>      x11grab
>>      zlib
>>  "
>> @@ -693,6 +689,8 @@
>>      getrusage
>>      imlib2
>>      inet_aton
>> +    linux_videodev_h
>> +    linux_videodev2_h
> 
> This is only needed if the config.h/mak definitions are required.
> AFAICT this is not the case, or they would have already been there.

Applied with this taken into account. Thanks for explaining.

Ramiro Polla