[FFmpeg-devel] av_first_bitstream_filter in avcodec.h

[Aurelien Jacobs]

On Fri, 14 Sep 2007 10:00:37 +0200
"Dean Pavlekovic" <dpavlekovic at gmail.com> wrote:

> Hi all,
> 
> Just one small thing, I've noticed that avcodec.h declares extern
> 'av_first_bitstream_filter' variable which isn't defined nor
> referenced anywhere else. However, there's 'first_bitstream_filter'
> defined in bitstream_filter.c.
> 
> $ grep -r first_bitstream_filter *
> libavcodec/avcodec.h:extern AVBitStreamFilter *av_first_bitstream_filter;
> libavcodec/bitstream_filter.c:AVBitStreamFilter *first_bitstream_filter= NULL;
> libavcodec/bitstream_filter.c:    bsf->next = first_bitstream_filter;
> libavcodec/bitstream_filter.c:    first_bitstream_filter= bsf;
> libavcodec/bitstream_filter.c:    AVBitStreamFilter *bsf=
> first_bitstream_filter;
> 
> So is this 'av_' difference a typo or the first_bitstream_filter isn't
> supposed to be exported, in which case the av_bitstream_filter
> declaration in avcodec.h is superfluous? Or something else

Indeed, I think it's not supposed to be exported.
Attached patch removes it.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: first_bsf.diff
Type: text/x-patch
Size: 512 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070916/0443d567/attachment.bin>