[FFmpeg-devel] [PATCH] configure - -pthread forced on some systems

[Ramiro Ribeiro Polla]

Diego Biurrun wrote:
> On Sat, Sep 15, 2007 at 10:44:41AM -0300, Ramiro Polla wrote:
>   
>> Fran?ois Revol wrote:
>>     
>>>> Why is -pthread forced on some systems? Shouldn't it depend on 
>>>> --enable-pthreads like in attached patch?
>>>>         
>>> Because some systems have an unfinished pthreads lib, so it's better to 
>>> use the native threading.
>>>       
>> I don't understand. Is it not caugt the same way (as -pthread) around 
>> configure:1533-1547, if --enable-pthreads is set?
>>     
>
> I think the comment is somewhat confused, so go ahead and apply your
> patch.
>   

I got help from a freebsd user on IRC to test the patch.

<deblin> caldo_de_cana: FYI, the freebsd port automatically adds 
--enable-pthreads and -pthread
<deblin> so while that may affect people compiling it outside of ports, 
it may not affect people in ports
[...]
<caldo_de_cana> are you testing outside of ports?
<deblin> yes
[...]
<deblin> % ldd ./ffmpeg | grep thr | wc -l 0
<deblin> ok, so without --enable-pthreads it doesn't link against 
pthread, so that's good. now with --enable-pthreads
<deblin> % ldd ./ffmpeg | grep thr libpthread.so.2 => 
/usr/lib/libthr.so.2 (0x2dc31000)
<deblin> worked
<deblin> that may or may not break on freebsd 5.x or 7.x...it works on 
6.2 though

Applied.

Ramiro Polla