[FFmpeg-devel] [PATCH] Add extralibs to dependency checker

[Måns Rullgård]

Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:

> Hello,
>
> Attached patch adds _extralibs to the dependency checker. Instead of
> having add_extralibs throughout configure, each item that needs an
> extra lib can specify it. It's also good as in the network and oss
> cases, where some systems need extra libs and some systems don't.
>
> Ramiro Polla
> Index: configure
> ===================================================================
> --- configure	(revision 10492)
> +++ configure	(working copy)
> @@ -303,14 +303,17 @@
>  
>          eval dep_all="\$${cfg}_deps"
>          eval dep_any="\$${cfg}_deps_any"
> +        eval dep_extralibs="\$${cfg}_extralibs"
>  
> -        pushvar cfg dep_all dep_any
> +        pushvar cfg dep_all dep_any dep_extralibs
>          check_deps $dep_all $dep_any
> -        popvar cfg dep_all dep_any
> +        popvar cfg dep_all dep_any dep_extralibs
>  
>          enabled_all $dep_all || disable $cfg
>          enabled_any $dep_any || disable $cfg
>  
> +        enabled $cfg && [ -n "$dep_extralibs" ] && add_extralibs $dep_extralibs
> +
>          disable ${cfg}_checking

Why the push/pop?  I can't see that it serves any purpose.  Rather,
compute dep_extralibs only after it's been determined that something
is to be enabled, like this:

if enabled $cfg; then
    eval dep_extralibs="\$${cfg}_extralibs"
    test -n "$dep_extralibs" && add_extralibs $dep_extralibs
fi

>      done
>  }
> @@ -750,12 +753,14 @@
>  
>  # external libraries
>  mpeg4aac_decoder_deps="libfaad"
> +liba52bin_decoder_extralibs='$ldl'

Hmm... there are probably enough evals to make this actually work.

-- 
M?ns Rullg?rd
mans at mansr.com