[FFmpeg-devel] [PATCH] configure - simplify zlib check

[Måns Rullgård]

Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:

> Hello,
>
> $subj
>
> Ramiro Polla
> Index: configure
> ===================================================================
> --- configure	(revision 10530)
> +++ configure	(working copy)
> @@ -743,6 +743,7 @@
>  wmv1_decoder_deps="h263_decoder"
>  wmv2_decoder_deps="h263_decoder"
>  wmv3_decoder_deps="h263_decoder"
> +zlib_deps="zlib_h"
>  zmbv_decoder_deps="zlib"
>  zmbv_encoder_deps="zlib"
>  
> @@ -1511,7 +1512,7 @@
>  check_header conio.h
>  
>  check_func inet_aton
> -enabled zlib && check_lib zlib.h zlibVersion -lz || disable zlib
> +check_lib zlib.h zlibVersion -lz
>  
>  # ffserver uses poll(),
>  # if it's not found we can emulate it using select().

That's not equivalent.  That said, I suppose it's unlikely that zlib.h
would exist and be something other than expected.  If we make that
assumption, we might as well just check for the header and skip the
full check_lib test.

In short, patch is not OK.

-- 
M?ns Rullg?rd
mans at mansr.com