[FFmpeg-devel] [PATCH] fix compiling VIS assembly on SPARC

[Diego Biurrun]

On Sat, Sep 22, 2007 at 04:52:41AM +0300, Jan Knutar wrote:
> On Friday 21 September 2007 12:36, Diego Biurrun wrote:
> > On Tue, Sep 18, 2007 at 11:19:40PM +0300, Jan Knutar wrote:
> > > On Tuesday 18 September 2007 16:46, Diego Biurrun wrote:
> > > > On Tue, Sep 18, 2007 at 06:50:14AM +0300, Jan Knutar wrote:
> > > > > On Tuesday 18 September 2007 03:23, Diego Biurrun wrote:
> > > > > > Somebody with some SPARC-fu please fix the attached patch.  I
> > > > > > just took the 23rd assembler line from
> > > > > > libavcodec/sparc/simple_idct_vis.c, it looked as good as any
> > > > > > of them ...
> > > > >
> > > > > The compiler will refuse to compile this unless
> > > > > -mcpu=ultrasparc How do you make configure run the tests with
> > > > > that flag set?
> > > >
> > > > That's easily solved.  Could somebody now test and fix my patch?
> > >
> > > Illegal operand or something such.
> > >
> > > How about this line of asm, stolen from
> > > libavcodec/sparc/dsputil_vis.c vis_level()
> >
> > Is it a VIS instruction?  Have you tested the patch to work?
> 
> I believe it's used in libavcodec/sparc to detect the presence of VIS.
> 
> I tested it on NetBSD and Solaris on VIS-enabled machines, and vis got 
> enabled by configure.

What happens on machines without VIS?

> Actual compilation fails in libswscale/yuv2rgb.c unless I add 
> -mcpu=ultrasparc

I have an idea how to take care of this, expect a patch soon.

Diego