[FFmpeg-devel] [PATCH] demux individual program out of MPEG-TS

[Nico Sabbi]

Il Sunday 23 September 2007 22:36:57 Michael Niedermayer ha scritto:
> >
> > +typedef struct AVProgram {
> > +    int            id;
> > +    char           *provider_name; ///< Network name for DVB
> > streams +    char           *name;          ///< Service name for
> > DVB streams +    int            running;
>
> can this be anything else than 0 and 1 if not a
> int flags; #define AV_PROGRAM_RUNNING 1 seems like a better choice
>

ok

>
> [...]
>
> >  AVStream *av_new_stream(AVFormatContext *s, int id);
> > +AVProgram *av_new_program(AVFormatContext *s, int i);
>
> s/i/id/

done

>
> > +void av_set_program_name(AVProgram *program, char
> > *provider_name, char *name);
>
> do we need that in the public lavf API? (we can always move it to
> avformat.h later but we cant remove it easiy once its in there ...)

removed from avformat.h and declared as extern void in mpegts.c

>
> except these iam fine with the patch, feel free to commit after
> dealing with the comments above, and if mans is ok with the changes
> to mpegts
>
>
> [...]

If no one objects tomorrow  I'll commit the following 3 patches in the 
order
P1 (AVProgram general) 
P2 (reuse of AVProgram in mpegts.c) 
P3 (program map and discard stuff in mpegts.c)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: P1.diff
Type: text/x-diff
Size: 3203 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070925/f2b58fd3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: P2.diff
Type: text/x-diff
Size: 3585 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070925/f2b58fd3/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: P3.diff
Type: text/x-diff
Size: 4303 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070925/f2b58fd3/attachment-0002.diff>