[FFmpeg-devel] [PATCH] Video decoder and demuxer for AMV files

[Michael Niedermayer]

Hi

On Sat, Sep 29, 2007 at 04:27:59PM +0700, Vladimir Voroshilov wrote:
> Now i undestand.
> Thanks you for detailed explamation.
> I have another question.
> 
> 
> According to this:
> 
> > > > use SEPERATE variables do NOT hack s->picture.data and s->linesize and then
> > > > revert that again a few lines later
> > > >
> 
> [...]
> 
> ..and this:
> > > Did i undestand you right (see patch)?
> >
> > argh, no!
> >
> > int linesize= s->linesize;
> > uint8_t *data[3]= {s->picture.data[0], ...
> >
> > if(amv){
> >     linesize= -linesize;
> >     for(i=0; i<3; i++)
> >         data[i]= ...
> > }
> >
> > use linesize+data
> >
> > and the patch which introduces the new variables should be seperate
> > from the one adding amv support
> 
> attached implementation is also not acceptable (and worse than hacking
> mjpeg_decode_scan).
> Am i right? Should i continue hacking mjpeg_decode_scan as you
> suggested or improve attached patch?

i would say hack mjpeg_decode_scan()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070929/01a26837/attachment.pgp>