[FFmpeg-devel] [PATCH] Demuxer for AMV files

[Michael Niedermayer]

Hi

On Sat, Sep 29, 2007 at 05:27:03PM +0200, Vitor Sessak wrote:
> Hi
> 
> Vladimir Voroshilov wrote:
> > Hi, All
> > 
> > Attached patch implements demuxer for AMV files.
> > AMV fourcc tag moved to the end of AVI tags array as suggested by Aurelian.
> > 
> > Discussion can be found
> > in "Video decoder and demuxer for AMV files" thread.
> > 
> > If patch is ok please apply.
> > 
> > P.S. AMV video decoder is required for this patch to be applied.
> 
> [...]
> 
> > +    int width=0, height=0;
> > +    int amv_file_format=0;
> >  
> >      avi->stream_index= -1;
> >  
> > @@ -276,6 +279,8 @@
> >              avi->is_odml = 1;
> >              url_fskip(pb, size + (size & 1));
> >              break;
> > +        case MKTAG('a', 'm', 'v', 'h'):
> > +            amv_file_format=1;
> >          case MKTAG('a', 'v', 'i', 'h'):
> >              /* avi header */
> >              /* using frame_period is bad idea */
> > @@ -286,8 +291,11 @@
> >  
> >              url_fskip(pb, 2 * 4);
> >              get_le32(pb);
> > +            get_le32(pb);
> > +            width=get_le32(pb);
> > +            height=get_le32(pb);
> 
> Sorry for not bring this up before, but wouldn't it be better to call 
> these variables "amv_width" and "amv_height" since they are AMV specific?

are they? what do they contain in normal avi files?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070929/fd3f0012/attachment.pgp>