[FFmpeg-devel] [PATCH]silence some useless warnings in mkv demuxer

[Anton Khirnov]

On Sat, May 31, 2008 at 6:52 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> On Fri, 30 May 2008 17:39:17 +0200
> "Anton Khirnov" <wyskas at gmail.com> wrote:
>
>> Hi,
>> this patch makes these warnings go away:
>>
>> Unknown entry 0x73a4 in info header (segment UID) - is now read
>> Unknown track header entry 0x55aa - ignoring (TrackFlagForced) - discard
>> Unknown track header entry 0x23314f - ignoring (TrackTimecodeScale) -
>> is used (is this ever different from 1?)
>> Unknown track header entry 0xaa - ignoring (CodecDecodeAll) - discard
>> Unknown attachedfile ID 0x46ae (File UID) - discard
>> Ignoring unknown Edition entry ID 0x45db (EditionFlagDefault) - discard
>
> This patch should be split a little.
>  - All the discarded ID could go in one patch.
>  - The TrackTimecodeScale should be in a separate patch.
>

Ok.

>
>  - The segment UID is not used in your patch, and thus, there is no reason
>   to read it. It should be discarded, as long as it's not used.
>

Same could be said for writing/muxing_app for example. But I don't
insist on it being there right now, so don't apply it if you don't
want to.

Anton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkv_discard_ids.patch
Type: text/x-patch
Size: 2554 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080601/9f05fc5e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkv_tracktimecodescale.patch
Type: text/x-patch
Size: 1780 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080601/9f05fc5e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkv_segmentuid.patch
Type: text/x-patch
Size: 1568 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080601/9f05fc5e/attachment-0002.bin>