[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

[Baptiste Coudurier]

Baptiste Coudurier wrote:
> Alexander Strange wrote:
>> On Jun 4, 2008, at 2:18 PM, Baptiste Coudurier wrote:
>>
>>> Michael Niedermayer wrote:
>>>> On Wed, Jun 04, 2008 at 08:09:02AM -0600, Jason Garrett-Glaser wrote:
>>>>>> Id just tell users to use FULL if they mean FULL ...
>>>>> IMO for consistency with other x264 options "esa" should be  
>>>>> available,
>>>>> but it should just be an alias for full.  Takes minimal code and  
>>>>> makes
>>>> ok
>>>>
>>>> but IMHO ESA is not a logic abbreviation for full search, just me 2  
>>>> cent
>>>>
>>>>
>>>>> the interface that little bit more user friendly, something that is
>>>>> sorely needed with x264 encoding under ffmpeg.
>>>> People prefer complaining about problems than working on  
>>>> solutions ...
>>>>
>>> Well I do work on solutions :>
>>> do we want ME_DIA too then ?
>>>
>>> Patch updated, with dia option.
>>> +{"dia", "tesa motion estimation (alias for epzs)", 0,  
>>> FF_OPT_TYPE_CONST, ME_EPZS, INT_MIN, INT_MAX, V|E, "me_method" },
>> "dia motion estimation"
> 
> Yes, noticed it, thanks, better be correct in documentation ;)
> 
>>>     /**
>>>      * Motion estimation algorithm used for video coding.
>>>      * 1 (zero), 2 (full), 3 (log), 4 (phods), 5 (epzs), 6 (x1), 7  
>>> (hex),
>>> -     * 8 (umh), 9 (iter) [7, 8 are x264 specific, 9 is snow specific]
>>> +     * 8 (umh), 9 (iter) [7, 8, 10 are x264 specific, 9 is snow  
>>> specific]
>> Mention 10 (tesa) here? It would be nice if it mentioned the  
>> Motion_Est_ID enum, but that's unrelated.
> 
> Yes, patch updated.
> 

Applied.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA