[FFmpeg-devel] [PATCH] add E-AC-3 support to AC-3 decoder

[Justin Ruggles]

Michael Niedermayer wrote:
> On Sat, Jun 07, 2008 at 06:49:05PM -0400, Justin Ruggles wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Jun 07, 2008 at 10:30:31AM -0400, Justin Ruggles wrote:
>>>> Hi,
>>>>
>>>> Here is a patch set to incrementally add support for E-AC-3 to the AC-3
>>>> decoder.  There are 32 total patches.  I'm just attaching them all in
>>>> this email instead of doing the git-send-email thing.
>>>>
>>>> diff --git a/libavcodec/ac3dec.h b/libavcodec/ac3dec.h
>>>> index fc73cf7..95e6512 100644
>>>> --- a/libavcodec/ac3dec.h
>>>> +++ b/libavcodec/ac3dec.h
>>>> @@ -63,14 +63,14 @@ typedef struct {
>>>>  ///@}
>>>>  
>>>>  ///@defgroup cpl standard coupling
>>>> -    int cpl_in_use;                         ///< coupling in use
>>>> -    int channel_in_cpl[AC3_MAX_CHANNELS];   ///< channel in coupling
>>>> -    int phase_flags_in_use;                 ///< phase flags in use
>>>> -    int phase_flags[18];                    ///< phase flags
>>>> -    int num_cpl_subbands;                   ///< number of coupling sub bands
>>>> -    int num_cpl_bands;                      ///< number of coupling bands
>>>> -    int cpl_band_struct[18];                ///< coupling band structure
>>>> -    int cpl_coords[AC3_MAX_CHANNELS][18];   ///< coupling coordinates
>>>> +    int cpl_in_use;                         ///< coupling in use (cplinu)
>>>> +    int channel_in_cpl[AC3_MAX_CHANNELS];   ///< channel in coupling (chincpl)
>>>> +    int phase_flags_in_use;                 ///< phase flags in use (phsflginu)
>>>> +    int phase_flags[18];                    ///< phase flags (phsflg)
>>>> +    int num_cpl_subbands;                   ///< number of coupling sub bands (ncplsubnd)
>>>> +    int num_cpl_bands;                      ///< number of coupling bands (ncplbnd)
>>>> +    int cpl_band_struct[18];                ///< coupling band structure (cplbndstrc)
>>>> +    int cpl_coords[AC3_MAX_CHANNELS][18];   ///< coupling coordinates (cplco)
>>> I think it would be clearer if the (names) where vertically aligned
>> PATCH 19 also needed to be revised based on this suggestion.  New patch
>> attached.
> 
> ok

applied patches 19, 20, and 21.

thanks,
Justin