[FFmpeg-devel] [MPlayer-dev-eng] rtp support in mplayer

[Diego Biurrun]

On Mon, Jun 09, 2008 at 01:38:26PM -0400, Chas Williams (CONTRACTOR) wrote:
> In message <20080516134500.8485095e.tempn at twmi.rr.com>,compn writes:
> >libavcodec patches go to ffmpeg-devel list.
> 
> here is a patch to libavcodec for g722 audio support.
> 
> --- mplayer-1.0rc2.orig/libavcodec/g722.c	2008-06-09 13:28:35.000000000 -0400
> +++ mplayer-1.0rc2/libavcodec/g722.c	2008-06-09 13:31:01.000000000 -0400
> @@ -0,0 +1,609 @@
> + *
> + * $Id$

Leave this out.

> +#if !defined(_G722_H_)
> +#define _G722_H_

Why?  This is not a header file.  Plus, identifiers starting with _ and
capital letters are reserved for the system.

> +/*
> + * SpanDSP - a series of DSP components for telephony
> + *
> + * g722_decode.c - The ITU G.722 codec, decode part.
> + *
> + * Written by Steve Underwood <steveu at coppice.org>
> + *
> + * Copyright (C) 2005 Steve Underwood
> + *
> + *  Despite my general liking of the GPL, I place my own contributions 
> + *  to this code in the public domain for the benefit of all mankind -
> + *  even the slimy ones who might try to proprietize my work and use it
> + *  to my detriment.
> + *
> + * Based in part on a single channel G.722 codec which is:
> + *
> + * Copyright (c) CMU 1993
> + * Computer Science, Speech Group
> + * Chengxiang Lu and Alex Hauptmann
> + *
> + * $Id$
> + */

Should this be a new file or what?

> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif

Non-system headers should use "" and there is no need for the #ifdef.

Diego