[FFmpeg-devel] [PATCH] dts parser fails to parse DTS-HD Master streams due to changing frame size

[Kostya]

On Wed, Jun 11, 2008 at 09:23:03AM +0200, Benjamin Larsson wrote:
> elupus wrote:
> > On Tue, 10 Jun 2008 22:57:44 +0200, elupus wrote:
> >
> >   
> >> Hi, 
> >>
> >> Currently the dts parser in lavc fails to parse dts-hd master streams due
> >> to them having changing framesizes. 
> >>
> >> For some reason the parser requries that the framesize's are equal. Can't
> >> really see why that should be required. So this patch removes that
> >> requirement.

The reason is called DCA specification where it is stated that all frame
sizes should be equal.

[...]
> 
> This might break some core streams. It might find markers at random and 
> send incomplete frames to the decoder.

It does. You should remember the reasons behind r12835 commit.
And that patch is just partial reverting of it.

> I guess the spec we have is 
> incomplete with regard to newer streams. I'll try to locate a problem 
> stream and see if this change breaks it.

I totally agree with that. Until we get the spec for those streams it's
pointless to change parser. So when I see the spec (and get the sample),
I'll change parser in correct way. Ignoring frame size is not correct.
 
> MvH
> Benjamin Larsson