[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Michael Niedermayer]

On Wed, Jun 18, 2008 at 08:29:16AM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> [...]
> >>> Besides a packet could be passed to more than 1 muxer and thus its content
> >>> must not be changed by any muxer.
> >> Ok; I tried to fix this bug, but I do not know if the attached patch
> >> is the best solution. It seems to work well here.
> > 
> > Iam not sure if its the best either ... maybe we should change
> > ff_avc_parse_nal_units to take a ByteIOContext ...
> > Of course only if it would end up simpler, if its not simpler than
> > your patch here is ok
> 
> Ok; this afternoon I'll try to have a look at passing a ByteIOContext as an
> argument (but first I have to understand why this can simplify things ;-).

writing straight vs. writing into a buffer, checking that something was
written and then put_buffer it ...


> 
> BTW, you said that you also found other muxers with the same problem...
> Can you post the list of such muxers (or the grep command you used)

grep ff_avc_parse_nal_units :)
the ones having a &pkt->data as argument are suspect ...


> somewhere? (in a roundup issue, or something)

will do unless you fix them as well :)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080618/9115e38d/attachment.pgp>