[FFmpeg-devel] [PATCH] fix two checks in ffserver.c

Wed Jun 18 23:32:37 CEST 2008

On Wed, Jun 18, 2008 at 10:37:24PM +0200, Stefan Gehrer wrote:
>  > @@ -1611,7 +1611,7 @@ static void compute_stats(HTTPContext *c)
>  >      url_fprintf(pb, "\r\n");
>  >
>  >      url_fprintf(pb, "<HEAD><TITLE>%s Status</TITLE>\n", program_name);
>  > -    if (c->stream->feed_filename)
>  > +    if (c->stream->feed_filename[0])
>  >          url_fprintf(pb, "<link rel=\"shortcut icon\" 
> href=\"%s\">\n", > c->stream->feed_filename);
>  >      url_fprintf(pb, "</HEAD>\n<BODY>");
>  >      url_fprintf(pb, "<H1>%s Status</H1>\n", program_name);
> 
> Even though the filename should be on heap and not on stack as you
> said (allocated in line 3897), this change looks sensible.

The struct stream is on the heap. But feed_filename is declared as:
char feed_filename[1024]

in the struct. So it will valid as long as stream is valid.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request