[FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg

[David LIU]

> From: ffmpeg-devel-bounces at mplayerhq.hu
[mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> Sent: Thursday, June 19, 2008 10:39 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg

> On Thu, Jun 19, 2008 at 09:34:00AM +0200, David LIU wrote:
>> On Wed, Jun 18, 2008 at 11:58:02AM +0200, David LIU wrote:
>> >> Hi,
>> >> 
>> >> Please review patch and let me know reject or accept
>> >> 
>> >> Best regards
>> 
>> [...]
>> 
>> >> (Also avoid top-posting.)
>>    ^^^^^^^^^^^^^^^^^^^^^^^
>> 
>> >besides that, ff_parse_close() should be used not a new redundant 
>> >function
>> added.
>> 
>> [David]: There is ParseContext type in ff_parse_close(). I have to use 
>> AACAC3ParseContext type and that's why I create new ff_parse_close2().

> AACAC3ParseContext contains a ParseContext, move it to the top and
AACAC3ParseContext is a ParseContext

[David]: This is correct and I agree your opinion then we can share
ff_parse_close(). My question is who and when will apply this patch if you
think this patch is useful.

[..]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope