[FFmpeg-devel] [PATCH] AAC Decoder - Round 2.

[Michael Niedermayer]

On Sat, Jun 21, 2008 at 06:12:06PM +0100, Robert Swain wrote:
> 2008/6/21 Michael Niedermayer <michaelni at gmx.at>:
> > On Sat, Jun 21, 2008 at 04:28:23PM +0100, Robert Swain wrote:
> >> 2008/6/20 Michael Niedermayer <michaelni at gmx.at>:
> >> > [...]
> >> >> +/**
> >> >> + * Program config. This describes how channels are arranged.
> >> >> + *
> >> >> + * Either read from stream (ID_PCE) or created based on a default
> >> >> + * fixed channel arrangement.
> >> >> + */
> >> >> +typedef struct {
> >> >> +    int che_type[4][MAX_TAGID];   ///< Channel Element type with the first index the first 4 raw_data_block IDs
> >> >> +
> >> >> +    int mono_mixdown;         ///< The SCE tag to use if user requests mono output,   -1 if not available
> >> >> +    int stereo_mixdown;       ///< The CPE tag to use if user requests stereo output, -1 if not available
> >> >> +    int mixdown_coeff_index;  ///< 0-3
> >> >> +    int pseudo_surround;      ///< Mix surround channels out of phase
> >> >> +
> >> >> +} program_config_struct;
> >> >
> >> > i would drop the _struct
> >> > one can always write "struct program_config" or ProgramConfig
> >> > other structs in lav* dont have struct in their names either ...
> >>
> >> I agree. I don't like the _struct suffix on _every_ struct. Would you
> >> prefer migration of all structs to 'ProgramConfig' style or maybe
> >
> > yes
> >
> >
> >> 'program_config_t' for typedef structs and 'program_config_s' for
> >
> > no, this one risks issues with posix ...
> 
> Is the attached OK? Do the names look acceptable to you?

yes, very nice

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080621/5e37e78e/attachment.pgp>