[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding

[Diego Biurrun]

On Wed, Jun 25, 2008 at 11:10:13AM +0700, Vladimir Voroshilov wrote:
> 2008/6/25 Diego Biurrun <diego at biurrun.de>:
> >> + *    Predicted fixed codebook gain gc_p is computed using from
> >> + *    known as predicted energies:
> >
> >
> > "The predicted..."
> >
> > But this is very confusing.  What are you trying to say by "using from
> > known as"?
> 
> Comment rewrited.
> 
> 'make checkheaders' also fixed in this file.
> Fix for other files will be sent in separate thread.
> 
> --- /dev/null
> +++ b/libavcodec/acelp_pitch_delay.h
> @@ -0,0 +1,232 @@
> +
> +#ifndef FFMPEG_ACELP_PITCH_LAG_H
> +#define FFMPEG_ACELP_PITCH_LAG_H

You forgot to update the multiple inclusion guard after the rename.

> + *    The predicted fixed codebook gain gc_p is found by predicting
> + *    the energy of the fixed-codebook contribution from the energy
> + *    of previous fixed-codebook contributions.

Perfect.

> +#endif // FFMPEG_ACELP_PITCH_LAG_H

Rename.

Diego