[FFmpeg-devel] [PATCH] mdec.c cleanups

[Alexander Strange]

On Jun 27, 2008, at 7:04 AM, Michael Niedermayer wrote:

> On Thu, Jun 26, 2008 at 10:03:56PM -0400, Alexander Strange wrote:
>> Inspired by Michael's psxstr cleanup.
>>
>> 1- Use reget_buffer().
>
> rejected, this might cause issues with double buffering and such, i  
> wont
> accept this without an explanation of why it should be changed. Also  
> moving
> reference afterwards is incorrect

I don't want to change the current behavior, so ok.


>> 2- Move setting the three different ways of being a keyframe into
>> decode_init, since they never change.
>
> rejected, i see no sense in this they should be set where the pic is  
> allocated
> and they are

Applied the ones after this.

>> 3- Remove unused PutBitContext since there's no encoder, and  
>> probably won't
>> be one.
>
> ok
>
>
>> 4- Fix and uncomment the code setting qscale_table.
>
> ok if it has been tested and works (postprocessing looks better)
>
>
>> 5- Remove commented-out code.
>
> ok
>
>
>> 6- Remove pointless emms_c(). Several other codecs have these lying  
>> around
>> too.
>
> ok
>
>
>> 7- Remove pointless casting to AVFrame*.
>
> ok