[FFmpeg-devel] [PATCH] Add ADPCM codec long_names

[Diego Biurrun]

On Thu, May 15, 2008 at 11:42:18PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Thu, May 15, 2008 at 06:08:24PM -0400, The Wanderer wrote:
> >> Aurelien Jacobs wrote:
> >> 
> >> > Stefano Sabatini wrote:
> >> > 
> >> >> Hi, as in subject,
> >> >> 
> >> >> please especially maintainers comment on the choice of the long_name
> >> >> for your maintained codecs.
> >> 
> >> >> +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_2, adpcm_sbpro_2, "Sound Blaster Pro 2 ADPCM");
> >> > 
> >> > Sound Blaster Pro 2 bits ADPCM
> >> 
> >> To be properly grammatical, this should be "2-bit" - similarly below.
> >
> > Why not simply "2 bit"?
> 
> Because that's not how English works.

:)

Fine, I'll make a mental note to use more hyphens.

Diego