[FFmpeg-devel] [PATCH]support for chapters in mkv container
Aurelien Jacobs
aurel
Wed May 21 00:30:03 CEST 2008
Anton Khirnov wrote:
> On Tue, May 20, 2008 at 12:14 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > Anton Khirnov wrote:
> >
> >> Ok, all done.
> >>
> >> [...]
> >>
> >> Index: libavformat/utils.c
> >> ===================================================================
> >> --- libavformat/utils.c (revision 13202)
> >> +++ libavformat/utils.c (working copy)
> >> @@ -2148,6 +2148,11 @@
> >> av_freep(&s->programs);
> >> flush_packet_queue(s);
> >> av_freep(&s->priv_data);
> >> + for(i = 0; i < s->num_chapters; i++) {
> >> + av_freep(&s->chapters[i]->title);
> >> + av_freep(&s->chapters[i]);
> >> + }
> >> + av_freep(&s->chapters);
> >
> > No, it seems you haven't applied every proposition from Michael.
> >
> > Aurel
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
> >
>
> Oops, shouldn't have programmed early in the morning :)
It seems morning is pretty long for you ;-)
> + while(s->num_chapters--) {
> + av_free(s->chapters[i]->title);
> + av_free(s->chapters[i]);
> + }
This is obviously wrong...
Aurel
More information about the ffmpeg-devel
mailing list