[FFmpeg-devel] [PATCH] fix unused variable warning in libswscale

Diego Biurrun diego
Tue Nov 4 09:42:47 CET 2008


On Tue, Nov 04, 2008 at 09:18:03AM +0100, Reinhard Tartler wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > Here is a small patch to eliminate an unused variable warning.
> >
> > --- libswscale/swscale_template.c	(revision 27889)
> > +++ libswscale/swscale_template.c	(working copy)
> > @@ -1826,11 +1826,12 @@
> >  
> >  static inline void RENAME(rgb24ToUV)(uint8_t *dstU, uint8_t *dstV, uint8_t *src1, uint8_t *src2, long width, uint32_t *unused)
> >  {
> > +#ifdef HAVE_MMX
> > +    assert(src1==src2);
> > +    RENAME(bgr24ToUV_mmx)(dstU, dstV, src1, width, PIX_FMT_RGB24);
> > +#elif
> >      int i;
> >      assert(src1==src2);
> > -#ifdef HAVE_MMX
> > -    RENAME(bgr24ToUV_mmx)(dstU, dstV, src1, width, PIX_FMT_RGB24);
> > -#else
> 
> are you sure with the double assert? Are you checking that src1 is still
> equal to src2 after RENAME?

I'm not changing the order of the assert..

Diego




More information about the ffmpeg-devel mailing list