[FFmpeg-devel] [PATCH] Function to parse Dirac sequence header

Michael Niedermayer michaelni
Fri Nov 7 23:46:32 CET 2008


On Fri, Nov 07, 2008 at 04:24:01AM -0500, David Conrad wrote:
> On Nov 6, 2008, at 5:15 AM, Diego Biurrun wrote:
>
>> On Wed, Nov 05, 2008 at 11:22:01PM -0500, David Conrad wrote:
>>>
>>> This will be useful for both the dirac parser and ogg demuxer (and
>>> future native dirac decoder of course.)
>>> Adapted from the soc repository.
>>>
>>> --- /dev/null
>>> +++ b/libavcodec/dirac.c
>>> @@ -0,0 +1,259 @@
>>> +    /* framerate */
>>> +    if (get_bits1(gb)) {
>>> +        source->frame_rate_index = svq3_get_ue_golomb(gb);
>>
>> This function is used in svq3.c, rv30.c, rv40.c and now dirac.c.
>> Clearly, the svq3_ prefix is misleading and it should be renamed.
>>
>> Does anybody have a suggestion for a better name?
>
> Going by what Kostya said, "get_ue_elias()"?

and what is this supposed to stand for?
ue_golomb was "unsigned exponential golomb"

iue_golomb for interleaved unsigned exponential golomb seems to make more
sense or iu_elias_gamma if we follow kostyas suggestion but thats longer
droping i, u or gamma makes it ambigous ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081107/331a5fcb/attachment.pgp>



More information about the ffmpeg-devel mailing list