[FFmpeg-devel] [PATCH] FLAC timestamp

[Yvan Labadie]

>
>> Send a unified diff please.
>>     
Sorry (noob inside) let's try again...
>> May I also suggest that a FLAC format demuxer should
>> reside in a file of its own?
>>     
>
> Yes, definitely.  It could also contain more than just setting the
> bitrate.  Ideally, the decoder would be revised so that it does not have
> to handle the header, including any metadata.  The demuxer would read
> the whole header and set the extradata.
>
> Regarding the patch, it doesn't take into account that the number of
> samples can be 0, indicating that it is unknown.  The patch assumes that
> seeking can be done, which is not always true.  Also, it contains tabs.
>
> -Justin
>
>   
I totaly agree that a "real" FLAC parser would be great, but don't have 
time for the moment... But that's a begining.

so modifications I just made :
    - if number of samples == 0, bit_rate is not processed
    - tabs a replaced with four whitespaces
    - to check if seeking can be done I check if we're not working on a 
stream, I'm not sure this is the better way but I do not know it there 
is another one...
    - flac operations removed from libavformat/raw.c add moved into a 
new file : libavformat/flac.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_flac.diff
Type: text/x-patch
Size: 4039 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/8389db1a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flac.c
Type: text/x-csrc
Size: 4441 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/8389db1a/attachment.c>