[FFmpeg-devel] [PATCH] QCELP decoder

[Michael Niedermayer]

On Thu, Nov 20, 2008 at 06:04:20PM -0800, Kenan Gillet wrote:
> Hi,
> On Nov 20, 2008, at 4:36 PM, Reynaldo H. Verdejo Pinochet wrote:
> 
> > Hello
> >
> > Reynaldo H. Verdejo Pinochet wrote:
[...]
> >
> >
> >> and I changed on the 10/27/2008 to
> >>     RATE_UNKNOWN = -2,
> >>     I_F_Q,             /*!< insufficient frame quality */
> >>     SILENCE,
> >>     RATE_OCTAVE,
> >>     RATE_QUARTER,
> >>     RATE_HALF,
> >>     RATE_FULL
> >> when you asked me to change the
> >> switch (framerate)
> >>   case RATE_FULL:
> >>   case RATE_QUARTER:
> >>   case RATE_OCTAVE:
> >> }
> >> to (framerate >= RATE_QUARTER)
> >>
> >> After sending the patch round 10, I also added a check to make sure
> >> the buffer
> >> contains enough data for the the frame to be decoded without reading
> >> garbage.
> >
> > I dont think that change is needed neither as that should be
> > guaranteed by your demuxer - parser(?) chain.
> 
> In order to read the two samples h263.mov and blue_earth.mov,
> we need to look at the rate byte in the frame (as the spec describes)
> and not just rely on the buffer_size
> since for those files, the buffer_size is always 35 but they contains
> RATE_FULL, RATE_HALF, RATE_QUARTER and RATE_OCTAVE.

and what is the rest of the 35 bytes?
trash? the next frame?
also do these files decode correctly?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081121/7eaa0c95/attachment.pgp>