[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Luca,

Thanks for your comments.

On Wed, Sep 17, 2008 at 5:11 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
>  > @@ -1323,6 +1338,7 @@
>  >          for (i = 0; i < rt->nb_rtsp_streams; i++) {
>  >              if (i != 0) av_strlcat(cmd, ",", sizeof(cmd));
>  >              ff_rdt_subscribe_rule(cmd, sizeof(cmd), i, 0);
>  > +            if (rt->transport == RTSP_TRANSPORT_RDT)
>  >              ff_rdt_subscribe_rule2(
>  >                  rt->rtsp_streams[i]->rtp_ctx,
>  >                  cmd, sizeof(cmd), i, 0);
>
> Why is only ff_rdt_subscribe_rule2() under the "RTSP_TRANSPORT_RDT" case?
> Isn't ff_rdt_subscribe_rule() RDT specific too? (otherwise, "ff_rdt_" is
> misleading).

I'll rename it ff_real_() in the end. Do you want that before or after
all other patches? (My plan was after.)

Ronald