[FFmpeg-devel] Google Summer of Code participation

[Michael Niedermayer]

On Fri, Apr 03, 2009 at 01:19:27AM +0200, Thilo Borgmann wrote:
[..]
>>> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
>>> index 4113382..eb732d2 100644
>>> --- a/libavcodec/utils.c
>>> +++ b/libavcodec/utils.c
>>> @@ -530,12 +530,39 @@ int attribute_align_arg 
>>> avcodec_decode_video(AVCodecContext *avctx, AVFrame *pic
>>>  {
>>>      int ret;
>>>  +    AVPacket avpkt;
>>> +    avpkt.data = buf;
>>> +    avpkt.size = buf_size;
>>> +
>>>      *got_picture_ptr= 0;
>>>      if((avctx->coded_width||avctx->coded_height) && 
>>> avcodec_check_dimensions(avctx,avctx->coded_width,avctx->coded_height))
>>>          return -1;
>>>      if((avctx->codec->capabilities & CODEC_CAP_DELAY) || buf_size){
>>> -        ret = avctx->codec->decode(avctx, picture, got_picture_ptr,
>>> -                                buf, buf_size);
>>>     
>>
>>   
>>> +            ret = avctx->codec->decode(avctx, picture, got_picture_ptr,
>>> +                                &avpkt);
>>> +
>>> +        emms_c(); //needed to avoid an emms_c() call before every 
>>> return;
>>>     
>>
>> indention if totally off
>>
>>   
> Sorry don't get that. The inserted line is one click too far to the 
> right... right?

yes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090403/6e27c0b9/attachment.pgp>