[FFmpeg-devel] [PATCH] fix speex sample

Michael Niedermayer michaelni
Thu Apr 9 00:46:16 CEST 2009


On Wed, Apr 08, 2009 at 02:49:44PM -0700, Baptiste Coudurier wrote:
> On 4/8/2009 2:28 PM, Michael Niedermayer wrote:
[...]
> > I can fix some and i will certainly not concentrate on ones that other
> > developers have a lot of interrest in and are capable to fix
> > because such bugs alraedy have people who will eventually fix them
> 
> So this means basically I can stop concentrate on _any_ bug since you
> are capable of fixing them ;)

> 
> > if someone submits a patch, the maintainer reviews it
> > its the same with patches from you to code maintained by me as it is
> > with patches by me to code maintained by you or mans.
> > IIRC you didnt fix every issue reimar pointed out in mp4/mov either.
> 
> Which ones ? AFAIK all isssues has been adressed except maybe the
> complete edit list support which is non trivial at _all_, but I applied
> somehow acceptable fix myself _based_ on Reimar patch. I just did not
> refuse it, and I based my efforts on his work, assuming my maintainer role.

what about binary codecs in mplayer with lavf or subtitles? i dont remember
exactly but i think there where some problems ...


> 
> The multiple stsd feature is implemented, and I submited a patch, it
> depends on one seeking fix in aviobuf.c, for which I also sent a patch.
> 
> Not mentioning that it takes me approximately 1 day to address issues on
> roundup relative to mov/mp4. Btw you are listed as maintainer for mov as
> well ;)
> 
> This is effectively a different kind of maintainership.

it is not, you can look at avidec/enc and its also pretty bug free, or
msmpeg4 or the mpeg1/2 decoder ...

flv is a little worse but not much
and then there is mpeg-ts & ffserver for which i belive you are maintainer
now, they are not even remotely close to bugfree not even close to flvdecs
bugfreeness.



> 
> >> but that's all right
> >> with me. Let's wait a few months ;)
> > 
> > you dont need to wait a few month before you fix your patch ;)
> 
> Well, like you said pretty well, I can spend my time on something else
> than something maintainer is able to fix ;)
> I don't have problem with this file personally, someone submited this
> file. I just don't like bugs.
> 
> If I were maintainer, I would have fixed it already, that's the whole
> point. I would even have addressed your comments on -cvslog and changed
> my original commit ;)

well, but you are not maintainer, and you will not become maintainer either
if that prevents you from fixing flvdec, thats a pitty, cant be helped i
guess.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090409/45b3964a/attachment.pgp>



More information about the ffmpeg-devel mailing list