[FFmpeg-devel] [PATCH] fix speex sample

[Reimar Döffinger]

On Thu, Apr 09, 2009 at 03:48:05PM +0200, Michael Niedermayer wrote:
> On Thu, Apr 09, 2009 at 09:33:26AM +0200, Diego Biurrun wrote:
> > On Wed, Apr 08, 2009 at 06:30:56PM -0700, Baptiste Coudurier wrote:
> [...]
> > Now while we're speaking of maintainer duties...  I agree with your
> > position much more than I agree with Michael's, but I have to point out
> 
> i think we should clarify once and for all what duties a maintainer has
> because people apply worse than double standards here
> and because this is a matter very critial to keeping the project functioning
> 
> Theres no question that until recently a submited patch was reviewed,
> and when suggestions for improvments where provided, the patch author
> then had to fix the patch if he wanted it in svn or explain why the
> suggestions where undesireable.
> 
> Do you propose that maintainers should fix patches themselfs now?
> Or do you propose that patches failing review should still be commited?
> Or do you propose not to review patches?
> 
> If none of above, then where do you disagree with me?

I think the disagreement is about what should happen when the patch
submitter is not willing or able to fix the patch so it passes review.
In particular depending on whether the patch is supposed to address a
feature request/bug/crash bug/exploitable security issue (not that we
would always even agree on the categorization) resolving the issue IMHO
can be considered the maintainer's responsibility.