[FFmpeg-devel] [PATCH] RTP/Vorbis payload implementation (GSoC qual task)

[Michael Niedermayer]

On Sun, Apr 12, 2009 at 09:54:49AM -0400, Ronald S. Bultje wrote:
> Hi Colin,
> 
> On Sun, Apr 12, 2009 at 2:27 AM, Colin McQuillan <m.niloc at googlemail.com> wrote:
> > This patch implements Vorbis over RTP.
> 
> > +        // remove the protocol identifier..
> > +        while (*p && *p == ' ')
> > +            p++;                // strip spaces.
> > +        while (*p && *p != ' ')
> > +            p++;                // eat protocol identifier
> > +        while (*p && *p == ' ')
> > +            p++;                // strip trailing spaces.
> 
> We (you, if we can all agree on a location before the deadline) should
> export get_word(), get_word_sep() and skip_spaces() so that all rtp
> modules can share it with rtsp.c.

I prefer the single line sscanf() over 3 function calls

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090412/09f36e42/attachment.pgp>